Hi Salminus, you ask a complex question here. I have both lenses, and they are both my favourites. Both excellent in that their IQ is very good, and easy to use, but they are very different in applicaton because of their range.
I would say that they are equal in their ability to resolve crisp, clear images with great contrast throughout their ranges, but their ranges are the issue in my opinion.
Give the same conditions, good lighting, bad lighting, with polarisers and high shutter speeds, both at 70mm there would likely be little difference in their resulting images.
If the fish is less than 6 meters from you, both will be ok. If the distance is greater, the 17-70 will have a small image in a large frame, and the 18-250 will be able to compensate for the distance, while losing light of course.
Tough call, it really is dependent on position, lighting, distance and whether a smaller image in a large frame can be cropped to be as good as a larger image zoomed closer with the 18-250, which was harder to shoot at say 160mm than the Sigma did at 70mm.
NOTE:
The Sigma 17-70 Objective lens DOES NOT ROTATE as you stated, no problems with polarizing filters at all.
Here are two images for comparison of the same subject, not a fish but you get the idea. The first is taken with the Sigma 17-70, the second with the Tamron 18-250. Taken at different times, so the lighting is somewhat changed.
And this one shot with the Tamron at 250mm as a nature comparison. I would never use the 17-70 for this purpose, unless the subject was a family pet and I could get in really close.
Hope this helps a bit
Phil